Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request 1: ADD mdx blog posts #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Pull Request 1: ADD mdx blog posts #5

wants to merge 6 commits into from

Conversation

ampahwa
Copy link

@ampahwa ampahwa commented Feb 23, 2022 •
edited
Loading

Added gatsby-node.js
Added dummy blog posts in content/blog
Modified Blog.js to show each mdx file frontmatter with minor styling

@netlify
Copy link

netlify bot commented Feb 23, 2022 •
edited
Loading

❌ Deploy Preview for anubislms failed.

🔨 Explore the source changes: 1c1b80b

🔍 Inspect the deploy log: https://app.netlify.com/sites/anubislms/deploys/621d6357c652dd00084e078e

synoet
synoet reviewed Feb 25, 2022
View reviewed changes
src/pages/blog.js Outdated Show resolved Hide resolved
synoet
synoet reviewed Feb 25, 2022
View reviewed changes
src/pages/blog.js Outdated Show resolved Hide resolved
synoet
synoet reviewed Feb 25, 2022
View reviewed changes
src/pages/blog.js Outdated Show resolved Hide resolved
synoet
synoet reviewed Feb 25, 2022
View reviewed changes
src/pages/blog.js Outdated Show resolved Hide resolved
@synoet
Copy link
Contributor

synoet commented Feb 25, 2022 •
edited
Loading

All in all a decent first PR, but its not quite ready to be merged.

Checklist of things that need to be done to merge:

  • Remove data that shouldn't be there
  • Clean up general code
  • Make your pr look nice. (Add a description of what you are doing what is is solving etc...)
  • Please make your commits more descriptive and follow the guidelines established on the contributing page.
  • dont push your yarn.lock file

@ampahwa ampahwa marked this pull request as draft February 28, 2022 20:50
@ampahwa ampahwa changed the title Set up gastby-node and a test md file Pull Request 1: ADD mdx blog posts Feb 28, 2022
@ampahwa ampahwa marked this pull request as ready for review February 28, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synoet synoet synoet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ampahwa @synoet @austinbarron